Repository navigation
Conversation
…ayed foreign thinking The CRAG branch rebuilds from the unfiltered caller body, so thinking signed outside this pool reached the provider and failed every turn. When the hop carried thinking this pool never issued, grade the signature 400 repairable even with failover.signature_repair off; forged probes on otherwise-own history still get the 400. Refs dofastted#1145
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 16, 2026
Owner
|
逐条复核:3.1.4 只覆盖空签名混合历史,不覆盖外来非空签名。 |
# Conflicts: # src/lib/pool/failover-runner.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1145
问题
CRAG 分支从未过滤的 caller body 重建 hopBody(为保留 CRAG 续接指纹),所以别处签发的历史 thinking 原样上送,每轮 400
Invalid signature in thinking block,要客户端自己去 thinking 重试。hop_meta.thinking_owner却记着dropped。改动
applyAttempt的 CRAG print 分支在 meta 里带foreignThinking(filterThinkingForAccount算出有 converted/dropped,即本池没签发过的签名)。FailoverRunner:signatureRepair = failover.signature_repair || attemptMeta.foreignThinking。命中签名 400 时走现有signature_repairable去 thinking 重试一次(CRAG 分支通过extra.repairs在重建后重放修复)。验证
failover-runner/upstream-error-policy/zero-retry-contract全过;全量单测失败集合与改动前一致。signature_repairable,重试 200。